Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced legacy babel-* & shorthand package name usage with @babel/* in README.md's #6820

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Replaced legacy babel-* & shorthand package name usage with @babel/* in README.md's #6820

merged 1 commit into from
Nov 17, 2017

Conversation

hulkish
Copy link
Contributor

@hulkish hulkish commented Nov 13, 2017 •
edited
Loading

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? N/A
Major: Breaking Change? N/A
Minor: New Feature? N/A
Tests Added + Pass? No + Yes
Documentation PR Yes
Any Dependency Changes? No
License MIT

@hulkish hulkish force-pushed the master branch 7 times, most recently from 9d70f3d to d5d9dfd Compare November 13, 2017 22:50
@hzoo hzoo added the PR: Docs 📝 A type of pull request used for our changelog categories label Nov 13, 2017
hzoo
hzoo reviewed Nov 13, 2017
View reviewed changes
experimental/babel-preset-env/CONTRIBUTING.md
@@ -20,7 +20,7 @@ And add them in this structure:

```js
// es2016
"@babel/transform-exponentiation-operator": {
Copy link
Member

@hzoo hzoo Nov 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this whole document is kind of out of date

babel/experimental/babel-preset-env/data/plugin-features.js

Lines 117 to 123 in 84fe8e4

const es2016 = {
"transform-exponentiation-operator": {
features: [
"exponentiation (**) operator",
],
}
};

referencing the old way to do things + wrong links

Copy link
Contributor Author

@hulkish hulkish Nov 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is fixed 👍 https://github.com/hulkish/babel/blob/master/experimental/babel-preset-env/CONTRIBUTING.md

@g0t4
Copy link

g0t4 commented Nov 14, 2017 •
edited
Loading

Is the shorthand format still valid to use? Or is it, or will it be, deprecated/removed in v7?

@existentialism
Copy link
Member

@g0t4 it's still valid for v7, just normalizing our docs to not use it since it's confused many people

@hulkish hulkish changed the title Removed shorthand plugin/preset usage in README.md's Removed legacy babel-* & shorthand package name usage in README.md's Nov 14, 2017
@hulkish hulkish changed the title Removed legacy babel-* & shorthand package name usage in README.md's Replaced legacy babel-* & shorthand package name usage with @babel/ in README.md's Nov 14, 2017
@hulkish hulkish changed the title Replaced legacy babel-* & shorthand package name usage with @babel/ in README.md's Replaced legacy babel-* & shorthand package name usage with @babel/* in README.md's Nov 14, 2017
existentialism
existentialism reviewed Nov 14, 2017
View reviewed changes
experimental/babel-preset-env/README.md Outdated
@@ -235,15 +235,15 @@ An array of plugins to always include.

Valid options include any:

- [Babel plugins](https://github.com/babel/babel-preset-env/blob/master/data/plugin-features.js) - both with (`@babel/plugin-transform-spread`) and without prefix (`transform-spread`) are supported.
- [Babel plugins](https://github.com/babel/babel-preset-env/blob/master/data/plugin-features.js) - both with (`@babel/plugin-transform-spread`) and without prefix (`@babel/plugin-transform-spread`) are supported.
Copy link
Member

@existentialism existentialism Nov 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @hzoo pointed out earlier, the include/exclude options in preset-env still need to get updated (kinda think we should do this in a separate PR? ¯\(ツ)/¯)

Relevant files:
index.js#L188
available-plugins.js
plugin-features.js

Also, the second shouldn't have a prefix as it's describing that shorthand is supported when declaring include/excludes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be #6825

@hulkish
Copy link
Contributor Author

hulkish commented Nov 16, 2017

@existentialism @g0t4 @hzoo alright how's that, guys?

hzoo
hzoo reviewed Nov 17, 2017
View reviewed changes
CONTRIBUTING.md

All the Babel plugins (and other packages) that have a `/test/fixtures` are written in a similar way.

For example, in [`babel-plugin-transform-exponentiation-operator/test`](https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-exponentiation-operator/test):
For example, in [`@babel/plugin-transform-exponentiation-operator/test`](https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-exponentiation-operator/test):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to change these because the folder names are still using - but I guess this is fine.

@hzoo hzoo merged commit cee9ae4 into babel:master Nov 17, 2017
@hzoo
Copy link
Member

hzoo commented Nov 17, 2017

thanks @hulkish !

@existentialism existentialism mentioned this pull request Nov 18, 2017
Closed
NMinhNguyen pushed a commit to NMinhNguyen/babel-plugin-transform-destructuring that referenced this pull request Aug 9, 2019
@hulkish @hzoo
[skip ci] removed shorthand usage of official babel scoped presets & …
c6e71f9 
…plugins from README.md's (babel#6820)
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism left review comments

@hzoo hzoo hzoo left review comments

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hulkish @g0t4 @existentialism @hzoo