Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite config chain tests to use public loadOptions API. #6909

Merged
merged 1 commit into from Nov 26, 2017

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Nov 25, 2017

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Purely unit test changes and rewrites.

@loganfsmyth loganfsmyth force-pushed the loganfsmyth:config-chain-tests branch from f738827 to 270dff1 Nov 25, 2017
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Nov 25, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5998/

@loganfsmyth loganfsmyth merged commit cdf420d into babel:master Nov 26, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.2% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:config-chain-tests branch Nov 26, 2017
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.