Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always transform for-await in async functions. #6953

Closed

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 1, 2017

Q                       A
Fixed Issues? #4969
Patch: Bug Fix? yes
Major: Breaking Change? yes?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

for-await was transformed in @babel/helper-remap-async-to-generator, which was called
by @babel/plugin-transform-async-to-generator and
@babel/plugin-proposal-async-generator-functions. This prevented for-await statements
in async functions to be transpiled if the transform-async-to-generator plugin was't
enabled.

This might be considered a breaking change, in case someone used for-await in async functions using just the async functions transform.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Generators labels Dec 1, 2017
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 2, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6152/

for-await was transformed in @babel/helper-remap-async-to-generator, which was called
by @babel/plugin-transform-async-to-generator and
@babel/plugin-proposal-async-generator-functions. This prevented for-await statements
in async functions to be transpiled if the transform-async-to-generator plugin was't
enabled.
@mattapperson
Copy link

@nicolo-ribaudo bump on this?

@nicolo-ribaudo
Copy link
Member Author

Waiting for reviews.
(And I have to fix the merge conflict, but I don't have time right now)

@mattapperson
Copy link

@nicolo-ribaudo anything I can do to help?

@nicolo-ribaudo
Copy link
Member Author

Moved to #7446

@nicolo-ribaudo nicolo-ribaudo deleted the for-await-async-fn branch March 5, 2018 08:26
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Generators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants