Async to generator fixes #6999
Merged
Async to generator fixes #6999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6139/ |
Jessidhia
added
7.x: regression
area: helpers
PR: Bug Fix 🐛
|
This will conflict with #6984 cc @nicolo-ribaudo |
|
That sounds like fun 😅 |
|
I'll rebase to exclude the commits that changed the helper-wrap-function; the changes in #6984 are better overall, just made some comments. |
Based on a fix suggested by @kzc
Jessidhia
force-pushed
the
async-to-generator-fixes
branch
from
8c314ae
to
401bce7
Compare
|
Done. This will still conflict with #6984 but the conflict should be very minor now. |
nicolo-ribaudo
approved these changes
Dec 8, 2017
existentialism
approved these changes
Dec 8, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes async arrow functions that are immediately invoked to not annotate the
asyncToGeneratorcall as pure. The original fix was suggested on #6973 (comment) but modified to also verify whether the callee is the arrow function itself, to make sure values given as arguments in a function call are still annotated as pure. An alternative would be to add parens, but I don't know of any way of doing it without making an invalid tree (e.g. wrapping in aSequenceExpressionwith only one element).