-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async to generator fixes #6999
Async to generator fixes #6999
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6139/ |
This will conflict with #6984 cc @nicolo-ribaudo |
That sounds like fun 😅 |
I'll rebase to exclude the commits that changed the helper-wrap-function; the changes in #6984 are better overall, just made some comments. |
Based on a fix suggested by @kzc
8c314ae
to
401bce7
Compare
Done. This will still conflict with #6984 but the conflict should be very minor now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the conflicts will be very easy to resolve.
I'll add the changes you removed from @babel/helper-wrap-function
to my pr.
Fixes async arrow functions that are immediately invoked to not annotate the
asyncToGenerator
call as pure. The original fix was suggested on #6973 (comment) but modified to also verify whether the callee is the arrow function itself, to make sure values given as arguments in a function call are still annotated as pure. An alternative would be to add parens, but I don't know of any way of doing it without making an invalid tree (e.g. wrapping in aSequenceExpression
with only one element).