Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant property declarations #7144

Merged
merged 1 commit into from Jan 2, 2018
Merged

Remove redundant property declarations #7144

merged 1 commit into from Jan 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR
Any Dependency Changes? No
License MIT

TsTypeAssertion unnecessarily redeclared properties already declared on TsTypeAssertionLikeBase.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6414/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6414/

nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nicolo-ribaudo nicolo-ribaudo merged commit 49775e2 into babel:master Jan 2, 2018
@ghost ghost deleted the rm_redundant_properties branch January 2, 2018 21:22
@existentialism existentialism added pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories labels Jan 3, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@babel-bot @nicolo-ribaudo @existentialism