Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flow to 0.66 and fix a few minor errors. #7431

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Looks like a few minor errors on the new version, and one regression in checking from #7404.

@@ -1068,6 +1068,8 @@ export type TsType =
| TsArrayType
| TsTupleType
| TsUnionOrIntersectionType
| TsConditionalType
| TsInferType
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @andy-ms I assume this was just missed in your PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganfsmyth Yep, thanks

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 26, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6956/

@loganfsmyth loganfsmyth merged commit 7ff4a73 into babel:master Feb 26, 2018
@loganfsmyth loganfsmyth deleted the flowtype-upgrade branch February 26, 2018 03:22
@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 26, 2018
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants