Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flow to 0.66 and fix a few minor errors. #7431

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Feb 26, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Looks like a few minor errors on the new version, and one regression in checking from #7404.

@@ -1068,6 +1068,8 @@ export type TsType =
| TsArrayType
| TsTupleType
| TsUnionOrIntersectionType
| TsConditionalType
| TsInferType

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth Feb 26, 2018

Author Member

cc @andy-ms I assume this was just missed in your PR?

This comment has been minimized.

Copy link
@andy-ms

andy-ms Feb 26, 2018

Contributor

@loganfsmyth Yep, thanks

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Feb 26, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6956/

@loganfsmyth loganfsmyth merged commit 7ff4a73 into babel:master Feb 26, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.64% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:flowtype-upgrade branch Feb 26, 2018
aminmarashi-binary added a commit to aminmarashi-binary/babel that referenced this pull request Mar 17, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.