Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Babel TypeScript Plugin #7443

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Conversation

orta
Copy link
Contributor

@orta orta commented Feb 27, 2018

Provides additional docs on what the trade-offs are for moving to Babel 7, and a few work-arounds.

The one that I'm not 100% on is the const enums. Would love some help on what the recommendation for replacing that could look like?

/cc @andy-ms @existentialism @DanielRosenwasser for ideas on that

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 27, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6975/

## Workarounds

* `namespace`: Migrate to defining modules instead.
* `const enum`: Avoid to using enums outside of current file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just change to enum (without const), which is available as a value at runtime and can be transpiled without type information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andy-ms - updated 👍

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer "compile" over "transpile" but I don't care enough to request changes. 😄 LGTM

@existentialism existentialism added PR: Docs 📝 A type of pull request used for our changelog categories area: typescript labels Mar 1, 2018
@existentialism existentialism merged commit fdfbd9a into babel:master Mar 1, 2018
@existentialism
Copy link
Member

@orta thanks!

aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants