Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to circleci v2 #7451

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Update to circleci v2 #7451

merged 1 commit into from
Feb 28, 2018

Conversation

danez
Copy link
Member

@danez danez commented Feb 28, 2018 •
edited

Q                       A
Fixed Issues? n
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes? n
License MIT

Builds are now also about 1 to 2 minutes faster

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 28, 2018
@danez danez force-pushed the update-circle branch 6 times, most recently from 6d66873 to 4f3b562 Compare February 28, 2018 10:09
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 28, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6998/

@danez
Copy link
Member Author

danez commented Feb 28, 2018 •
edited

Netlify or the website repo needs to be changed for this, as the artifacts have different urls now. But i'm not sure where.

Okay seems to work now after I fixed the artifacts in cci, netlify seems to automatically adjust.

@hzoo hzoo merged commit 586ba35 into master Feb 28, 2018
@danez danez deleted the update-circle branch February 28, 2018 16:00
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@danez @aminmarashi
Update to circleci v2 (babel#7451)
c437484
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danez @babel-bot @existentialism @hzoo