Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS transform plugin README updatex2 #7469

Merged
merged 1 commit into from
Mar 3, 2018
Merged

Conversation

orta
Copy link
Contributor

@orta orta commented Mar 2, 2018

Took in the extra feedback and updated the doc again.

@babel-bot
Copy link
Collaborator

babel-bot commented Mar 2, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7049/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7045/


## Workarounds

* `namespace`: Migrate to using the `module { }` syntax instead.
* `namespace`: Move to using [file exports][fm], or migrate to using the `module { }` syntax instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on combining the workaround next to its caveat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@orta
Copy link
Contributor Author

orta commented Mar 2, 2018

How does this feel?

@existentialism
Copy link
Member

Works for me, maybe later someone can spruce it up with examples (not high priority), thanks @orta!

@existentialism existentialism merged commit 53208d6 into babel:master Mar 3, 2018
@existentialism existentialism added PR: Docs 📝 A type of pull request used for our changelog categories area: typescript labels Mar 3, 2018
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants