Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate more packages' tests to use jest expect assertions #7720

Merged
merged 6 commits into from
Apr 13, 2018
Merged

Migrate more packages' tests to use jest expect assertions #7720

merged 6 commits into from
Apr 13, 2018

Conversation

devenbansod
Copy link
Contributor

@devenbansod devenbansod commented Apr 12, 2018 •
edited

Q                       A
Fixed Issues? Working towards #7476
Patch: Bug Fix? NA
Major: Breaking Change? Yes, removed chai.assert from the context in which test fixtures are run
Minor: New Feature? NA
Tests Added + Pass? 👍
Documentation PR NA
Any Dependency Changes? NA
License MIT
  • Migrate -optional-catch-binding, -block-scoping to use jest expect assertions
  • Migrate -transform-classes tests to use jest expect assertions
  • Migrate -transform-object-super tests to use jest expect assertions
  • Migrate -computed-properties and -jscript tests to use jest expect assertions

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 12, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7587/

@nicolo-ribaudo
Copy link
Member

LGTM 👍

It just needs to be rebased after #7721

@devenbansod
Copy link
Contributor Author

devenbansod commented Apr 13, 2018 •
edited

@nicolo-ribaudo thanks for the previous review.

  • Rebased over current master
  • Have removed the injection of assert into the global context in latest commits (also made me realize some missing instances to be migrated, when those tests failed as I removed assert from the context).
  • Added breaking change comment in the PR Q&A

@nicolo-ribaudo nicolo-ribaudo added area: tests PR: Internal 🏠 A type of pull request used for our changelog categories labels Apr 13, 2018
@hzoo hzoo merged commit 7a10602 into babel:master Apr 13, 2018
@devenbansod devenbansod deleted the migrate_to_jest_expect-3 branch April 13, 2018 15:06
@jridgewell
Copy link
Member

👍

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devenbansod @babel-bot @nicolo-ribaudo @jridgewell @hzoo