Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gulp@4 #7811

Merged
merged 1 commit into from Apr 25, 2018

Conversation

@existentialism
Copy link
Member

existentialism commented Apr 25, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? n/y
Documentation PR
Any Dependency Changes?
License MIT

The test262/flow test jobs have been breaking on Travis since node 10 was released, which looks like a bug with gulp@3 and node 10.

The number of changes wound up being pretty minimal to get things going again, so we can save the debate about replacing gulp for later :)

(This felt better than locking the jobs to node 8)

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7730/

@hzoo
hzoo approved these changes Apr 25, 2018
@hzoo hzoo merged commit 0112479 into master Apr 25, 2018
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.73% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Apr 25, 2018

Awesome, thanks Brian

@existentialism existentialism deleted the bump-gulp branch Apr 25, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.