Support Flow's proto modifier syntax for declared classes #7978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwgoldman
changed the title
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8207/ |
| @@ -321,6 +321,7 @@ defineType("ObjectTypeProperty", { | |||
| value: validateType("FlowType"), | |||
| kind: validate(assertOneOf("init", "get", "set")), | |||
| static: validate(assertValueType("boolean")), | |||
| proto: validate(assertValueType("proto")), | |||
There was a problem hiding this comment.
boolean?
Also, can we assert that the property isn't both statc and proto?
existentialism
added
PR: New Feature 🚀
See facebook/flow@eb815be for more information about this feature. The proto modifier indicates that a property declared using `x: T` syntax is actually present on the prototype object of the class, rather than an own property. The proto and static modifiers are mutually exclusive, as class declarations don't simultaneously define the static prototype object, as they do the instance prototype. This syntax is only supported on declared classes, not object types, interfaces, or runtime class declarations, and as such should only appear in library definitions.
existentialism
force-pushed
the
proto-props
branch
from
fe96b4e
to
3bdaee1
Compare
|
Rebased, and updated to assert @nicolo-ribaudo we can probably just follow up with both an exclusive assertion util and updating the builder? |
nicolo-ribaudo
approved these changes
May 25, 2018
existentialism
added a commit
to prettier/prettier
that referenced
this pull request
May 25, 2018
Flow commit: facebook/flow@eb815be Babel PR: babel/babel#7978
storyn26383
pushed a commit
to UniSharp/babel
that referenced
this pull request
Aug 6, 2018
<!-- Before making a PR please make sure to read our contributing guidelines https://github.com/babel/babel/blob/master/CONTRIBUTING.md For issue references: Add a comma-separated list of a [closing word](https://help.github.com/articles/closing-issues-via-commit-messages/) followed by the ticket number fixed by the PR. It should be underlined in the preview if done correctly. --> | Q | A <!--(Can use an emoji 👍) --> | ------------------------ | --- | Fixed Issues? | <!-- remove the (`) quotes to link the issues --> | Patch: Bug Fix? | | Major: Breaking Change? | No | Minor: New Feature? | Yes | Tests Added + Pass? | Yes | Documentation PR | <!-- If so, add `[skip ci]` to your commit message to skip CI --> | Any Dependency Changes? | | License | MIT See facebook/flow@eb815be for more information about this feature. The proto modifier indicates that a property declared using `x: T` syntax is actually present on the prototype object of the class, rather than an own property. The proto and static modifiers are mutually exclusive, as class declarations don't simultaneously define the static prototype object, as they do the instance prototype. This syntax is only supported on declared classes, not object types, interfaces, or runtime class declarations, and as such should only appear in library definitions.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See facebook/flow@eb815be for more information about this feature.
The proto modifier indicates that a property declared using
x: Tsyntax is actually present on the prototype object of the class, rather than an own property.The proto and static modifiers are mutually exclusive, as class declarations don't simultaneously define the static prototype object, as they do the instance prototype.
This syntax is only supported on declared classes, not object types, interfaces, or runtime class declarations, and as such should only appear in library definitions.