Bigint Support (no transform) #8006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
added
the
PR: Bug Fix 🐛
hzoo
commented
May 22, 2018
| @@ -143,3 +143,12 @@ export function StringLiteral(node: Object) { | |||
|
|
|||
| return this.token(val); | |||
| } | |||
|
|
|||
| export function BigIntLiteral(node: Object) { | |||
There was a problem hiding this comment.
FYI: I noticed this is the same code as above without the need for jsesc so not sure if we care about reusing stuff. Someone can feel free to edit make the commits necessary
There was a problem hiding this comment.
I think it's fine to keep the separate
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8119/ |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7873
Taken from #6015, @wdhorton
No transform included on purpose