New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all filenames as absolute paths, rather than relative. #8044

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
3 participants
@loganfsmyth
Member

loganfsmyth commented May 25, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

In #7956 I made the filename options consistent, but I had to choose between absolute and relative. At the time I chose relative, but I think it would be more consistent with expectations from babel-loader if it were absolute instead.

These concerns were raised in #7956 (comment) so it it has caused issues for people.

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot May 25, 2018

Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8192/

Collaborator

babel-bot commented May 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8192/

@loganfsmyth loganfsmyth merged commit 53e4d74 into babel:master May 25, 2018

4 checks passed

babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.58% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@loganfsmyth loganfsmyth deleted the loganfsmyth:absolute-filename branch May 25, 2018

eventualbuddha added a commit to square/babel-codemod that referenced this pull request May 29, 2018

fix(package): update babel dependencies for path fix
Incorporates a change that was breaking babel-codemod's tests: babel/babel#8044.

eventualbuddha added a commit to square/babel-codemod that referenced this pull request May 29, 2018

fix(package): update babel dependencies for path fix
Incorporates a change that was breaking babel-codemod's tests: babel/babel#8044.

ThiefMaster added a commit to indico/react-jsx-i18n that referenced this pull request Jun 6, 2018

Convert paths to relative
Recent babel versions always use absolute paths (babel/babel#8044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment