Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all filenames as absolute paths, rather than relative. #8044

Merged
merged 1 commit into from May 25, 2018

Conversation

@loganfsmyth
Copy link
Member

@loganfsmyth loganfsmyth commented May 25, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

In #7956 I made the filename options consistent, but I had to choose between absolute and relative. At the time I chose relative, but I think it would be more consistent with expectations from babel-loader if it were absolute instead.

These concerns were raised in #7956 (comment) so it it has caused issues for people.

@loganfsmyth loganfsmyth force-pushed the loganfsmyth:absolute-filename branch from fd4a726 to 986f39c May 25, 2018
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented May 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8192/

@loganfsmyth loganfsmyth merged commit 53e4d74 into babel:master May 25, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.58% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:absolute-filename branch May 25, 2018
eventualbuddha added a commit to codemod-js/codemod that referenced this pull request May 29, 2018
Incorporates a change that was breaking babel-codemod's tests: babel/babel#8044.
eventualbuddha added a commit to codemod-js/codemod that referenced this pull request May 29, 2018
Incorporates a change that was breaking babel-codemod's tests: babel/babel#8044.
ThiefMaster added a commit to indico/react-jsx-i18n that referenced this pull request Jun 6, 2018
Recent babel versions always use absolute paths (babel/babel#8044)
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.