Expose all filenames as absolute paths, rather than relative. #8044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
added
the
PR: Bug Fix 🐛
loganfsmyth
force-pushed
the
absolute-filename
branch
from
fd4a726
to
986f39c
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8192/ |
existentialism
approved these changes
May 25, 2018
eventualbuddha
added a commit
to codemod-js/codemod
that referenced
this pull request
May 29, 2018
Incorporates a change that was breaking babel-codemod's tests: babel/babel#8044.
eventualbuddha
added a commit
to codemod-js/codemod
that referenced
this pull request
May 29, 2018
Incorporates a change that was breaking babel-codemod's tests: babel/babel#8044.
ThiefMaster
added a commit
to indico/react-jsx-i18n
that referenced
this pull request
Jun 6, 2018
Recent babel versions always use absolute paths (babel/babel#8044)
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7956 I made the
filenameoptions consistent, but I had to choose between absolute and relative. At the time I chose relative, but I think it would be more consistent with expectations frombabel-loaderif it were absolute instead.These concerns were raised in #7956 (comment) so it it has caused issues for people.