Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module compilation in 7.0.0-beta.2 includes the full file paths #226

Closed
dfreeman opened this issue Jun 7, 2018 · 3 comments
Closed

Module compilation in 7.0.0-beta.2 includes the full file paths #226

dfreeman opened this issue Jun 7, 2018 · 3 comments

Comments

@dfreeman
Copy link
Contributor

dfreeman commented Jun 7, 2018

If I upgrade to ember-cli-babel@7.0.0-beta.2 in a fresh app (generated from ember-cli@3.1.4), the module names for everything under app include the full path on disk where they originated, e.g.

define("/Users/dfreeman/Desktop/Scratch Code/babel-7-app/babel-7-app/app", ["exports", "/Users/dfreeman/Desktop/Scratch Code/babel-7-app/babel-7-app/resolver", "ember-load-initializers", "/Users/dfreeman/Desktop/Scratch Code/babel-7-app/babel-7-app/config/environment"], function (_exports, _resolver, _emberLoadInitializers, _environment) {
  "use strict";
  // ...

Presumably module names should match those generated by ember-cli-babel@6.x?

@rwjblue
Copy link
Member

rwjblue commented Jun 8, 2018

Yes, definitely a bug. Thank you for reporting!

@dfreeman
Copy link
Contributor Author

Probably related to babel/babel#8044? Poking around, both amd-name-resolver and @babel/plugin-transform-modules-amd (the latter via @babel/core's getModuleName) seem like they're assuming relative paths.

@rwjblue
Copy link
Member

rwjblue commented Mar 9, 2021

This has been resolved (a loooooong time ago), closing...

@rwjblue rwjblue closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants