Do not quote JSX attribute keys for IdentifierName #8045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following
```js
a = <F new/>
```
We used to generate:
```js
a = React.createElement(F, {"new": true})
```
but now we generate
```js
a = React.createElement(F, {new: true})
```
If you need to quote these (ie for ES3 you can use
transform-property-literals)
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8195/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8195/ |
nicolo-ribaudo
approved these changes
May 25, 2018
|
What is the process for merging this? |
|
Two approved reviews |
|
I'm just wondering why we don't quote everything? |
|
@xtuc Do you quote all your keys in object literals? In member expressions? |
jridgewell
approved these changes
May 26, 2018
|
@arv quoting every key would simplify the logic here and it's in the generated code. |
xtuc
approved these changes
May 27, 2018
|
@xtuc The code here is pretty simple and the gain in readability in the generated code makes it worth it. Plus, quoting keys had some bad side effects for people using Closure Compiler further down their build pipeline. |
|
Thanks, @jridgewell |
hzoo
added
PR: Breaking Change 💥
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following
We used to generate:
but now we generate
If you need to quote these (for ES3 for example, you can use transform-property-literals)