Don't split an exported class when renaming an inner binding #8051
Conversation
nicolo-ribaudo
commented
May 25, 2018
•
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #8062, Fixes #8033, Fixes #7951, Fixes #7843 |
| Patch: Bug Fix? | 👍 |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
| @@ -0,0 +1,9 @@ | |||
| export class Foo extends Bar { | |||
There was a problem hiding this comment.
The problem was that when ...args was renamed to ...args2, this export declaration was split.
For some reason classPath.parentPath was set to classPath instead of programPath. I'll investigate it, but this PR "workarounds" the problem by only splitting the export declaration when necessary.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8206/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8206/ |
|
@nicolo-ribaudo I added a bunch more issues to your "Fixed issues" list. Could you look them over and make sure they are the same problem, and see if there are any other tests cases we should add? |
|
Should we land this in the meantime? |
lock
bot
added
the
outdated
