Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change decoratorsBeforeExport default to false #8113

Merged

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jun 4, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? 👍
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Ref: #7976 (comment) (cc @diervo)

I also asked to Daniel, and he said that this option could be removed but

I am not 100% sure, we will have to confirm, but it could always be added back

Instead of removing the option, this PR changes the default value to false.

@@ -263,8 +263,7 @@ export default class StatementParser extends ExpressionParser {
this.raise(
this.state.start,
"Using the export keyword between a decorator and a class is not allowed. " +
"Please use `export @dec class` instead, or set the " +
"'decoratorsBeforeExport' option to true.",
"Please use `export @dec class` instead.",

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Jun 4, 2018

Author Member

Since it looks like that the propoal is going to change, I removed the suggestion of using that option.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jun 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8288/

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:decorators-remove-before-export branch from 735a7a8 to ccd5755 Jun 4, 2018
@hzoo
hzoo approved these changes Jun 4, 2018
@xtuc
xtuc approved these changes Jun 4, 2018
@nicolo-ribaudo nicolo-ribaudo merged commit 6349118 into babel:master Jun 4, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.55% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:decorators-remove-before-export branch Jun 4, 2018
storyn26383 pushed a commit to UniSharp/babel that referenced this pull request Aug 6, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.