Change decoratorsBeforeExport default to false #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Jun 4, 2018
| @@ -263,8 +263,7 @@ export default class StatementParser extends ExpressionParser { | |||
| this.raise( | |||
| this.state.start, | |||
| "Using the export keyword between a decorator and a class is not allowed. " + | |||
| "Please use `export @dec class` instead, or set the " + | |||
| "'decoratorsBeforeExport' option to true.", | |||
| "Please use `export @dec class` instead.", | |||
There was a problem hiding this comment.
Since it looks like that the propoal is going to change, I removed the suggestion of using that option.
nicolo-ribaudo
added
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8288/ |
nicolo-ribaudo
force-pushed
the
decorators-remove-before-export
branch
from
735a7a8
to
ccd5755
Compare
hzoo
approved these changes
Jun 4, 2018
xtuc
approved these changes
Jun 4, 2018
storyn26383
pushed a commit
to UniSharp/babel
that referenced
this pull request
Aug 6, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #7976 (comment) (cc @diervo)
I also asked to Daniel, and he said that this option could be removed but
Instead of removing the option, this PR changes the default value to false.