Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel/parser: remove dead code: constant condition #8177

Merged
merged 1 commit into from Jun 15, 2018
Merged

babel/parser: remove dead code: constant condition #8177

merged 1 commit into from Jun 15, 2018

Conversation

GerHobbelt
Copy link
Contributor

@GerHobbelt GerHobbelt commented Jun 15, 2018 •
edited

Q                       A
Fixed Issues? -
Patch: Bug Fix? -
Major: Breaking Change? -
Minor: New Feature? -
Minor: Code cleanup / typo fixes? 👍
Tests Added + Pass? Yes
Documentation PR -
Any Dependency Changes? -
License MIT

See diff. Trivial cleanup.

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 15, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8397/

xtuc
xtuc approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Andarist Andarist added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Jun 15, 2018
@Andarist Andarist merged commit ba98cf7 into babel:master Jun 15, 2018
storyn26383 pushed a commit to UniSharp/babel that referenced this pull request Aug 6, 2018
@GerHobbelt @Andarist
Removed constant condition in parser (babel#8177)
116190d
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GerHobbelt @babel-bot @xtuc @Andarist