Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Types] fix generated TS/Flow comment types #9007

Merged
merged 1 commit into from Nov 9, 2018

Conversation

@ljqx
Copy link
Contributor

@ljqx ljqx commented Nov 9, 2018

Q                       A
Fixed Issues? Fixes #8969
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No need
Documentation PR Link None
Any Dependency Changes? No
License MIT

As described in #8969, the generated TS/Flow types for comments are not aligned with the ones used by @babel/parser. This change makes them same as the real types used in code.
Specifically:
BlockComment => CommentBlock
LineComment => CommentLine

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 9, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9367/

@xtuc
xtuc approved these changes Nov 9, 2018
@xtuc xtuc added the pkg: types label Nov 9, 2018
@existentialism existentialism merged commit 4dfd801 into babel:master Nov 9, 2018
4 checks passed
4 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 80.68% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@existentialism
Copy link
Member

@existentialism existentialism commented Nov 9, 2018

@ljqx thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants