Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip minifying standalone in non-publish runs #9094

Merged
merged 1 commit into from Nov 28, 2018
Merged

Skip minifying standalone in non-publish runs #9094

merged 1 commit into from Nov 28, 2018

Conversation

@danez
Copy link
Member

danez commented Nov 28, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This only minifies the standalone packages when publishing. We already skipped it on CI, because it is not necessary for the tests. Now it is also skipped in dev unless it is called from publish. I think unless one is working on the standalone packages it is not really necessary to always minify.

Also added a message that states if it is skipped or not.
screen shot 2018-11-27 at 3 58 50 pm
screen shot 2018-11-27 at 4 02 22 pm

Also remove unused dependency on uglify js. gulp-uglify uses its own version.

Also remove unused dependency on uglify js. gulp-uglify uses its own version.
@hzoo
hzoo approved these changes Nov 28, 2018
@danez danez merged commit 559d649 into master Nov 28, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.61% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@danez danez deleted the skip-minify-on-dev branch Nov 28, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.