babel-types is* type checks accept null | undefiend as value TS type #9539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10167/ |
danez
approved these changes
Feb 22, 2019
nicolo-ribaudo
approved these changes
Feb 22, 2019
|
The CI failure is unrelated to this PR. |
danez
added
the
PR: Bug Fix 🐛
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is*functions for checking a node type in babel-types accept anything as thevalueargument, and will returnfalseifvalueisnullorundefinedor anything which is not a valid node/path of that type.The currently TypeScript definitions imply that the function does not accept anything which is not an
objectwhich is incorrect. Updating this to allowanyas is actually the case.