Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-types is* type checks accept null | undefiend as value TS type #9539

Merged
merged 3 commits into from Feb 22, 2019
Merged

babel-types is* type checks accept null | undefiend as value TS type #9539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bda3fb
babel-types is* type checks accept null | undefiend as value TS type
ian-craig Feb 18, 2019
ed03387
Use | null | undefined instead of any, make Flow type nullable
ian-craig Feb 18, 2019
7966722
Also change flow types of generated src
danez Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-types/scripts/generators/flow.js
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@ for (const type in t.NODE_FIELDS) {
for (let i = 0; i < t.TYPES.length; i++) {
let decl = `declare function is${
t.TYPES[i]
}(node: Object, opts?: ?Object): boolean`;
}(node: ?Object, opts?: ?Object): boolean`;

if (t.NODE_FIELDS[t.TYPES[i]]) {
decl += ` %checks (node instanceof ${NODE_PREFIX}${t.TYPES[i]})`;
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-types/scripts/generators/generateValidators.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ function addIsHelper(type, aliasKeys, deprecated) {
" === nodeType";
}

return `export function is${type}(node: Object, opts?: Object): boolean {
return `export function is${type}(node: ?Object, opts?: Object): boolean {
${deprecated || ""}
if (!node) return false;

Expand Down
2 changes: 1 addition & 1 deletion packages/babel-types/scripts/generators/typescript.js
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ for (const type in t.NODE_FIELDS) {
for (let i = 0; i < t.TYPES.length; i++) {
let decl = `export function is${
t.TYPES[i]
}(node: object, opts?: object | null): `;
}(node: object | null | undefined, opts?: object | null): `;

if (t.NODE_FIELDS[t.TYPES[i]]) {
decl += `node is ${t.TYPES[i]};`;
Expand Down