Add placeholders support to @babel/types and @babel/generator #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10427/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10177/ |
danez
reviewed
Feb 20, 2019
packages/babel-generator/test/fixtures/misc/.placeholders/input.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
force-pushed
the
placeholders/2-types
branch
from
0500381
to
a79a0df
Compare
danez
reviewed
Feb 26, 2019
There was a problem hiding this comment.
The change makes sense to me and not controversial at all.
I guess that most of the time nobody will see Placeholders in the AST anyway as it will be exclusively used by @babel/template, right?
That makes me wonder though if the changes to @babel/types are actually necessary? As long as
there is no error thrown I would think they are not really needed unless @babel/template needs them?
|
Yeah, 99% of the times they will only be used by
|
danez
approved these changes
Feb 26, 2019
nicolo-ribaudo
force-pushed
the
placeholders/2-types
branch
from
a79a0df
to
759049d
Compare
existentialism
approved these changes
Mar 5, 2019
|
%%:+1:%% |
nicolo-ribaudo
added
PR: Ready to be Merged
nicolo-ribaudo
force-pushed
the
placeholders/2-types
branch
from
759049d
to
f88d6ac
Compare
mAAdhaTTah
added a commit
to mAAdhaTTah/babel
that referenced
this pull request
Mar 15, 2019
* master: (58 commits) Remove dependency on home-or-tmp package (babel#9678) [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (babel#9628) Partial application plugin (babel#9474) Private Static Class Methods (Stage 3) (babel#9446) gulp-uglify@3.0.2 rollup@1.6.0 eslint@5.15.1 jest@24.5.0 regexpu-core@4.5.4 Remove input and length from state (babel#9646) Switch from rollup-stream to rollup and update deps (babel#9640) System modules - Hoist classes like other variables (babel#9639) fix: Don't transpile ES2018 symbol properties (babel#9650) Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI (babel#9647) Update regexpu-core dependency (babel#9642) Add placeholders support to @babel/types and @babel/generator (babel#9542) Generate plugins file Make babel-standalone an ESModule and enable flow (babel#9025) Reorganize token types and use a map for them (babel#9645) [TS] Allow context type annotation on getters/setters (babel#9641) ...
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9364, but those two PRs can be merged in any order.
The "core" of this PR is at https://github.com/babel/babel/pull/9542/files#diff-70f395c5d000299ece93fa4d13b656f9R18: does it make sense? That same logic is replicated for the
is[Type]helpers.