Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regexpu-core dependency #9642

Merged
merged 2 commits into from Mar 7, 2019
Merged

Update regexpu-core dependency #9642

merged 2 commits into from Mar 7, 2019

Conversation

mathiasbynens
Copy link
Contributor 

yarn upgrade regexpu-core@4.5.3

This should resolve the issue @danez mentions here:
#9636 (comment)

@mathiasbynens
Copy link
Contributor Author

I'm a yarn n00b and probably messed up updating the yarn.lock file. What's the proper way of doing this in the Babel monorepo? (Looking at the diff, it seems to have added regexpu-core as a root dependency, which was not my intention.)

@babel-bot
Copy link
Collaborator

babel-bot commented Mar 6, 2019 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10424/

@buildsize
Copy link

buildsize bot commented Mar 6, 2019 •
edited

File name Previous Size New Size Change
babel-preset-env.js 2.04 MB 2.04 MB -537 bytes (0%)
babel-preset-env.min.js 1.09 MB 1.09 MB -262 bytes (0%)
babel.js 2.76 MB 3.61 MB 871.46 KB (31%)
babel.min.js 1.54 MB 2.17 MB 652.77 KB (41%)

@mathiasbynens
Copy link
Contributor Author

So, the @BuildSize bot just confirmed that I messed up the yarn.lock update. 😅

@nicolo-ribaudo
Copy link
Member

I can check It again. I'm sorry but yesterday it was the first time I edited a yarn.lock file and I did it by trial and error, so I don't how to suggest fixing it by yourself 😅

@existentialism
Copy link
Member

existentialism commented Mar 6, 2019 •
edited

@mathiasbynens mind if I update the branch? Think I have the lockfile fixed!

@danez
Copy link
Member

danez commented Mar 7, 2019

I use this tool a lot: https://github.com/atlassian/yarn-deduplicate

@mathiasbynens
Copy link
Contributor Author

@existentialism No need to ask, just go for it! Thanks ♥

@mathiasbynens
Update regexpu-core dependency
f501146 
yarn upgrade regexpu-core@4.5.3

This should resolve the issue @danez mentions here:
#9636 (comment)
@mathiasbynens
Copy link
Contributor Author

@danez After reverting my incorrect yarn.lock changes, I ran npx yarn-deduplicate yarn.lock, but it didn’t have any effect. 🤷🏼‍♂️

@danez
Copy link
Member

danez commented Mar 7, 2019

@danez After reverting my incorrect yarn.lock changes, I ran npx yarn-deduplicate yarn.lock, but it didn’t have any effect. 🤷🏼‍♂️

The tool is supposed to fix incorrect yarn.lock files, so it might have worked before reverting the changes. I pushed the lock file.

@mathiasbynens
Copy link
Contributor Author

@danez You fixed it!
image

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 7, 2019
Merged
@mathiasbynens mathiasbynens merged commit 7c909e8 into master Mar 7, 2019
@mathiasbynens mathiasbynens deleted the regexpu-core-4.5.3 branch March 7, 2019 15:40
@mathiasbynens
Copy link
Contributor Author

regexpu-core@4.5.4 is out with a bugfix. Does anyone want to do the honors and submit a PR? :)

mAAdhaTTah added a commit to mAAdhaTTah/babel that referenced this pull request Mar 15, 2019
@mAAdhaTTah
Merge branch 'master' into implement-f#-pipeline-in-parser
7458063 
* master: (58 commits)
  Remove dependency on home-or-tmp package (babel#9678)
  [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (babel#9628)
  Partial application plugin (babel#9474)
  Private Static Class Methods (Stage 3) (babel#9446)
  gulp-uglify@3.0.2
  rollup@1.6.0
  eslint@5.15.1
  jest@24.5.0
  regexpu-core@4.5.4
  Remove input and length from state (babel#9646)
  Switch from rollup-stream to rollup and update deps (babel#9640)
  System modules - Hoist classes like other variables (babel#9639)
  fix: Don't transpile ES2018 symbol properties (babel#9650)
  Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI (babel#9647)
  Update regexpu-core dependency (babel#9642)
  Add placeholders support to @babel/types and @babel/generator (babel#9542)
  Generate plugins file
  Make babel-standalone an ESModule and enable flow (babel#9025)
  Reorganize token types and use a map for them (babel#9645)
  [TS] Allow context type annotation on getters/setters (babel#9641)
  ...
@mathiasbynens mathiasbynens mentioned this pull request Mar 20, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mathiasbynens @babel-bot @nicolo-ribaudo @existentialism @danez