Disallow escape sequences in contextual keywords #9618
Conversation
danez
added
PR: Bug Fix 🐛
| @@ -704,11 +712,11 @@ export default class ExpressionParser extends LValParser { | |||
|
|
|||
| atPossibleAsync(base: N.Expression): boolean { | |||
| return ( | |||
| !this.state.containsEsc && | |||
There was a problem hiding this comment.
containsEsc only says if the current token has escape sequences. Here it already references the token after async which is not what we want, hence the slice check.
| node.arguments = this.parseCallExpressionArguments( | ||
| tt.parenR, | ||
| possibleAsync, | ||
| ); |
There was a problem hiding this comment.
I removed this, as I don't see a what an OptionalCallExpression has anything todo with the async keyword. No tests failed or changed. I guess this was copied wrong.
| @@ -525,12 +525,21 @@ export default class ExpressionParser extends LValParser { | |||
| startLoc: Position, | |||
| noCalls?: ?boolean, | |||
| ): N.Expression { | |||
| const maybeAsyncArrow = this.atPossibleAsync(base); | |||
There was a problem hiding this comment.
moving it from line 624 to here, basically prevents (async)(a) => {}.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10376/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10356/ |
| if (possibleAsync && this.shouldParseAsyncArrow()) { | ||
| if ( | ||
| maybeAsyncArrow && | ||
| !this.canInsertSemicolon() && |
There was a problem hiding this comment.
!this.canInsertSemicolon() prevents
async (x)
=> {}
There was a problem hiding this comment.
Maybe we could move the check inside shouldParseAsyncArrow?
Also note that both flow and TS allow this code:
async (f)
: t => { }but disallow
async (f) : t
=> { }There was a problem hiding this comment.
Thanks, I added testcases and moved it into shouldParseAsyncArrow
lock
bot
added
the
outdated
Resolves two problems:
async, as, of, get, set, static, ...The cases which were parsing successfully with escape sequences (although shouldn't) were: async in almost all cases. get & set in classes.
Also added tests for a lot of cases that were already correctly working.