Explain the double negatives a bit better #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was correct; just needed some clarification I felt.
|
Good idea |
| @@ -192,7 +192,7 @@ browserify().transform(babelify, { | |||
| }); | |||
| ``` | |||
|
|
|||
| The above example will transform all files except those in the `node_modules` directory that are not in `node_modules/app`. | |||
| The above example will result in a transform that also includes the `app` module in `node_modules`: the `global` flag transforma all files, and the `ignore` regular expression then excludes all those in the `node_modules` directory *except* those that are in `node_modules/app`. | |||
There was a problem hiding this comment.
Can you fix the transforma typo? I can squash so just edit it again.
If you want you can explain what ! is doing too
|
Thanks @jamesgpearce! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was correct; just needed some clarification I felt.