Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Babel 7 #244

Closed
wants to merge 1 commit into from
Closed

Upgrade to Babel 7 #244

wants to merge 1 commit into from

Conversation

pioug
Copy link

@pioug pioug commented Sep 22, 2017

I did the upgrade to Babel 7.0.0-beta.3.

I removed the arrayify functions. It's a breaking change but it's aligned with https://babeljs.io/blog/2017/03/01/upgrade-to-babel-7#option-parsing if I understand correctly.

So if anyone has more insight 馃檹 I'd like to know so I can update the PR.

I remove the tests for Node <= 0.12 since it is not supported anymore https://babeljs.io/blog/2017/03/01/upgrade-to-babel-7-for-tool-authors#all-babel-packages-node-js-support

UPDATE: Just found a similar PR #242 馃樁

@oztune
Copy link

oztune commented Oct 8, 2017

Would it make sense to make babel-core a peerDependency? This way at least minor versions can be upgraded independently of this package. tsify does this and it seems to work for them.

@pioug
Copy link
Author

pioug commented Oct 9, 2017

@oztune Good point! Just checked babel-loader does something similar https://github.com/babel/babel-loader/blob/master/package.json#L18-L19

Thanks for reviewing 馃檹

@oztune
Copy link

oztune commented Nov 10, 2017

@hzoo Do you think this is ready for use with babel@7.0.0-beta.x?

@pioug
Copy link
Author

pioug commented Apr 5, 2018

Closing, see #255 instead.

@pioug pioug closed this Apr 5, 2018
@pioug pioug deleted the babel7 branch April 5, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants