Upgrade to Babel 7 and @babel scoped packages #255

ylemkimon · 2017-12-30T11:20:01Z

Change dependencies/require to use @babel scoped packages
Use asynchronous babel.transform
Replace removed functions/properties: babel.util.arrayify, babel.util.canCompile, result.metadata.usedHelpers
Even without sourceFileName, Babel 7 maps source files to absolute path, if sourceMapsAbsolute is false(default), set sourceFileName to its base name
Updated test cases

Fixes #254, fixes #251, fixes #231

vcarel · 2018-01-16T09:31:08Z

Hi, can this PR be merged? What about the unit test mentioned above?

ylemkimon · 2018-01-18T09:48:28Z

@vcarel This PR can be merged without any problems, but the tests will not cover error emission.

julien-f · 2018-01-24T16:48:18Z

Would it be difficult to keep the compatibility with Babel 6 and support Babel 7 through babel-core@bridge?

loganfsmyth · 2018-01-24T16:52:32Z

@julien-f Generally me and the Babel team have been recommending against using the bridge unless you really are in a place where you have to support multiple versions via one package, but using gulp-babel doesn't seem like a case where that is likely to be needed.

julien-f · 2018-01-24T16:54:26Z

Makes sense, thanks :)

krazyjakee · 2018-01-29T21:53:48Z

@ylemkimon Great PR but I can't seem to get your version to compile without throwing the ParseError: 'import' and 'export' may appear only with 'sourceType: module' error. There's no reason this shouldn't work while browserify has 7x version of @babel/preset-env set as a preset.

Check this out: https://github.com/Keyframes/Keyframes.Pathfinder
Clone and run npm install && npm run build

EDIT: Ok, this works now. Needed to set the --global flag on babelify as it can't require from node_modules. What a hot mess.

connorjclark · 2018-02-14T06:39:40Z

Can a beta be published?

goto-bus-stop · 2018-03-02T10:16:19Z

I think we can replace babel-plugin-undeclared-variables-check in test/error.js with something else that throws an error. Maybe @babel/plugin-transform-classes with a snippet like this?

class A {
  // calling super() w/o a superclass
  constructor () { super() }
}

ylemkimon · 2018-03-06T07:02:52Z

@krazyjakee Sorry for late response. You don't have to transpile the file(npm run es6). That's what babelify does do, and you can and must pass ES6 Javascript file browserify with babelify.

ylemkimon · 2018-03-06T09:18:20Z

@goto-bus-stop Thank you for the idea! Actually, this revealed a bug which calls callback, even if transform has failed.

ylemkimon · 2018-03-06T09:19:34Z

@vcarel @hoten Now it's ready to be merged or published.

clubajax · 2018-03-08T15:46:32Z

I'm using ylemkimon's fork and it's working.
"babelify": "github:ylemkimon/babelify"

clarfonthey · 2018-03-14T18:10:22Z

Any plans to merge this soon?

chaines · 2018-03-30T19:25:36Z

Not a huge fan of using a fork. Any chance this can be merged?

futagoza · 2018-04-02T13:45:45Z

@hzoo Any plans to merge this?

@ylemkimon This should also close the previous related PR's: #241, #242, #244, #252

hzoo · 2018-04-06T20:07:52Z

Sorry for delay, yeah I wasn't watching this repo actually!

We should update the readme too (doesn't have to be in this PR)

loganfsmyth · 2018-04-06T20:21:45Z

index.js

-      ? Object.assign({sourceFileName: filename}, opts)
-      : opts;
+    var _opts = Object.assign({sourceFileName: sourceMapsAbsolute
+      ? filename : path.basename(filename)}, opts);


In the body, you say

Even without sourceFileName, Babel 7 maps source files to absolute path, if sourceMapsAbsolute is false(default), set sourceFileName to its base name

Could you clarify? Is this change attempting to fix an issue that was also present with Babel 6.x, or something that has regressed in 7.x? It feels like using the basename here is likely to leave to conflicts where multiple files for instance have the name index.js for instance.

hzoo

Sorry for the delay y'all 😓! Been busy with stuff so I appreciate everyone's work on this PR since it seems we had a lot of submissions as well.

chrisgervang · 2018-04-16T02:38:59Z

Thank you so much for approving! I'm looking forward to using this. Can someone merge and release a beta? Much appreciated!

hzoo · 2018-04-18T14:33:28Z

We had a question in #255 (comment), but to land I'll just revert that.

hzoo · 2018-04-18T14:38:19Z

Ok releasing this as 9.0.0-beta.0 then. Seeing 2 test failures..

Just FYI but we're still a small group of volunteers and looking for more maintainers and help (I'm not really watching this repo anymore). If you'd like to help out it would be appreciated (via maintenance on babel projects or donating to our open collective or my patreon)

hzoo · 2018-04-18T14:52:57Z

Ok yeah need to determine if #255 (review) is a regression or not before release - makes more sense now.

Blinnikov · 2018-04-19T11:28:58Z

Could you release it as alpha if this unresolved question is so important?

chrisgervang · 2018-04-19T22:17:40Z

@hzoo I didn't know you had a patreon! Awesome. I just signed up :)

These probably got copy pasted incorrectly in babel#255

goto-bus-stop · 2018-04-20T09:09:46Z

Hm yeah, it looks like babel-core@6 defaulted parserOpts.sourceFileName to basename(opts.filename), whereas @babel/core@7 defaults it to just opts.filename.

This deals with a problem mentioned in [babel/babelify#255][0]. I'm not super sure about the implications, but it seems this may have been a regression from Babel 6. In babel@6, the default `sourceFileName` was the basename of the input file: ```js require('babel-core').transform('var a = 10', { filename: __filename, sourceMaps: true }).map // { version: 3, // sources: [ 'index.js' ], // names: [ 'a' ], // mappings: 'AAAA,IAAIA,IAAI,EAAR', // file: 'index.js', // sourcesContent: [ 'var a = 10' ] } } ``` Currently however, the full file path is used: ```js require('@babel/core').transformSync('var a = 10', { filename: __filename, sourceMaps: true }).map // { version: 3, // sources: [ '/home/goto-bus-stop/Code/babel/repro-babelify-255/index.js' ], // names: [ 'a' ], // mappings: 'AAAA,IAAIA,IAAI,EAAR', // file: '/home/goto-bus-stop/Code/babel/repro-babelify-255/index.js', // sourcesContent: [ 'var a = 10' ] } } ``` This patch adds the `path.basename()` call that [Babel 6 used][1] to @babel/core's default options, so it's the same as back then. ```js require('../babel/packages/babel-core').transform('var a = 10', { filename: __filename, sourceMaps: true }).map // { version: 3, // sources: [ 'index.js' ], // names: [ 'a' ], // mappings: 'AAAA,IAAIA,IAAI,EAAR', // sourcesContent: [ 'var a = 10' ] } ``` This is the desired behaviour for browserify at least, as it expects relative paths in the source maps and rebases them to a root directory when generating the final source map. [0]: babel/babelify#255 [1]: https://github.com/babel/babel/blob/6689d2d23cdb607c326ed5a06855bfb84c050c56/packages/babel-core/src/transformation/file/index.js#L163-L172

* Fix default sourceFileName. This deals with a problem mentioned in [babel/babelify#255][0]. I'm not super sure about the implications, but it seems this may have been a regression from Babel 6. In babel@6, the default `sourceFileName` was the basename of the input file: ```js require('babel-core').transform('var a = 10', { filename: __filename, sourceMaps: true }).map // { version: 3, // sources: [ 'index.js' ], // names: [ 'a' ], // mappings: 'AAAA,IAAIA,IAAI,EAAR', // file: 'index.js', // sourcesContent: [ 'var a = 10' ] } } ``` Currently however, the full file path is used: ```js require('@babel/core').transformSync('var a = 10', { filename: __filename, sourceMaps: true }).map // { version: 3, // sources: [ '/home/goto-bus-stop/Code/babel/repro-babelify-255/index.js' ], // names: [ 'a' ], // mappings: 'AAAA,IAAIA,IAAI,EAAR', // file: '/home/goto-bus-stop/Code/babel/repro-babelify-255/index.js', // sourcesContent: [ 'var a = 10' ] } } ``` This patch adds the `path.basename()` call that [Babel 6 used][1] to @babel/core's default options, so it's the same as back then. ```js require('../babel/packages/babel-core').transform('var a = 10', { filename: __filename, sourceMaps: true }).map // { version: 3, // sources: [ 'index.js' ], // names: [ 'a' ], // mappings: 'AAAA,IAAIA,IAAI,EAAR', // sourcesContent: [ 'var a = 10' ] } ``` This is the desired behaviour for browserify at least, as it expects relative paths in the source maps and rebases them to a root directory when generating the final source map. [0]: babel/babelify#255 [1]: https://github.com/babel/babel/blob/6689d2d23cdb607c326ed5a06855bfb84c050c56/packages/babel-core/src/transformation/file/index.js#L163-L172 * Use cwd-relative path for sourceFileName. * Revert sourceMap `file` property change. * fixup! Revert sourceMap `file` property change. * Fix whitespace change from merge conflict * Revert to using basename in source map outputs.

sorenlouv · 2018-05-05T19:05:42Z

@hzoo Shouldn't this change be published to npm?

Current workaround to use babelify with Babel 7:

"babelify": "git+https://git@github.com/babel/babelify.git#c5e4d4"

goto-bus-stop · 2018-05-05T19:07:07Z

@sqren please see #263, this is waiting on a new babel core release to address #255 (review)

sorenlouv · 2018-05-05T19:10:23Z

@goto-bus-stop Okay, thanks!

These probably got copy pasted incorrectly in babel#255

These probably got copy pasted incorrectly in #255

ylemkimon added 2 commits December 20, 2017 01:16

Support Babel 7

20ad2c6

Update browserify-cli.js

a369126

ylemkimon changed the title ~~Support Babel 7 and @babel scoped packages~~ Upgrade to Babel 7 and @babel scoped packages Dec 30, 2017

anthony-redFox mentioned this pull request Jan 25, 2018

Add support for Babel 7 documentationjs/documentation#996

Closed

ylemkimon added 4 commits March 6, 2018 18:12

Remove Babel 6 from peer dependencies

b87de6f

Do not call callback if error occured

783fe7d

Change error case to calling super() w/o a superclass

efb0cfc

Update package-lock.json

ac3ed1a

Delagen mentioned this pull request Mar 12, 2018

[ES] migrate to mocha & nyc, ES code refactor, split bundle NaturalIntelligence/fast-xml-parser#64

Closed

hzoo requested a review from loganfsmyth April 2, 2018 14:27

pioug mentioned this pull request Apr 5, 2018

Upgrade to Babel 7 #244

Closed

This was referenced Apr 6, 2018

switch to babel-preset-env #241

Closed

babel-preset-env && babel@next #242

Closed

Feature - scope babel 7 support #252

Closed

update readme [skip ci]

c6e6906

loganfsmyth reviewed Apr 6, 2018

View reviewed changes

hzoo approved these changes Apr 6, 2018

View reviewed changes

revert small change [skip ci]

1b65b35

hzoo merged commit c5e4d40 into babel:master Apr 18, 2018

goto-bus-stop added a commit to goto-bus-stop/babelify that referenced this pull request Apr 20, 2018

Fix --presets use in CLI examples

cf94014

These probably got copy pasted incorrectly in babel#255

goto-bus-stop mentioned this pull request Apr 20, 2018

Fix --presets use in CLI examples #262

Merged

goto-bus-stop mentioned this pull request Apr 20, 2018

Fix default sourceFileName. babel/babel#7764

Merged

larsgw mentioned this pull request Apr 29, 2018

Ignore option throwing errors #265

Closed

goto-bus-stop added a commit to goto-bus-stop/babelify that referenced this pull request May 18, 2018

Fix --presets use in CLI examples

fb5831a

These probably got copy pasted incorrectly in babel#255

loganfsmyth pushed a commit that referenced this pull request Sep 3, 2018

Fix --presets use in CLI examples (#262)

6dfe29f

These probably got copy pasted incorrectly in #255

snyk-bot mentioned this pull request Nov 6, 2019

[Snyk] Upgrade babelify from 7.3.0 to 10.0.0 ajesse11x/remix-ide#5

Open

snyk-bot mentioned this pull request Dec 8, 2019

[Snyk] Upgrade babelify from 6.4.0 to 10.0.0 drakeg/choosealicense.com#3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Babel 7 and @babel scoped packages #255

Upgrade to Babel 7 and @babel scoped packages #255

ylemkimon commented Dec 30, 2017 •

edited

Loading

vcarel commented Jan 16, 2018

ylemkimon commented Jan 18, 2018

julien-f commented Jan 24, 2018

loganfsmyth commented Jan 24, 2018

julien-f commented Jan 24, 2018

krazyjakee commented Jan 29, 2018 •

edited

Loading

connorjclark commented Feb 14, 2018 •

edited

Loading

goto-bus-stop commented Mar 2, 2018

ylemkimon commented Mar 6, 2018

ylemkimon commented Mar 6, 2018

ylemkimon commented Mar 6, 2018

clubajax commented Mar 8, 2018

clarfonthey commented Mar 14, 2018

chaines commented Mar 30, 2018

futagoza commented Apr 2, 2018

hzoo commented Apr 6, 2018

loganfsmyth Apr 6, 2018

hzoo left a comment

chrisgervang commented Apr 16, 2018

hzoo commented Apr 18, 2018

hzoo commented Apr 18, 2018 •

edited

Loading

hzoo commented Apr 18, 2018

Blinnikov commented Apr 19, 2018

chrisgervang commented Apr 19, 2018

goto-bus-stop commented Apr 20, 2018

sorenlouv commented May 5, 2018 •

edited

Loading

goto-bus-stop commented May 5, 2018 •

edited

Loading

sorenlouv commented May 5, 2018

Upgrade to Babel 7 and @babel scoped packages #255

Upgrade to Babel 7 and @babel scoped packages #255

Conversation

ylemkimon commented Dec 30, 2017 • edited Loading

vcarel commented Jan 16, 2018

ylemkimon commented Jan 18, 2018

julien-f commented Jan 24, 2018

loganfsmyth commented Jan 24, 2018

julien-f commented Jan 24, 2018

krazyjakee commented Jan 29, 2018 • edited Loading

connorjclark commented Feb 14, 2018 • edited Loading

goto-bus-stop commented Mar 2, 2018

ylemkimon commented Mar 6, 2018

ylemkimon commented Mar 6, 2018

ylemkimon commented Mar 6, 2018

clubajax commented Mar 8, 2018

clarfonthey commented Mar 14, 2018

chaines commented Mar 30, 2018

futagoza commented Apr 2, 2018

hzoo commented Apr 6, 2018

loganfsmyth Apr 6, 2018

Choose a reason for hiding this comment

hzoo left a comment

Choose a reason for hiding this comment

chrisgervang commented Apr 16, 2018

hzoo commented Apr 18, 2018

hzoo commented Apr 18, 2018 • edited Loading

hzoo commented Apr 18, 2018

Blinnikov commented Apr 19, 2018

chrisgervang commented Apr 19, 2018

goto-bus-stop commented Apr 20, 2018

sorenlouv commented May 5, 2018 • edited Loading

goto-bus-stop commented May 5, 2018 • edited Loading

sorenlouv commented May 5, 2018

ylemkimon commented Dec 30, 2017 •

edited

Loading

krazyjakee commented Jan 29, 2018 •

edited

Loading

connorjclark commented Feb 14, 2018 •

edited

Loading

hzoo commented Apr 18, 2018 •

edited

Loading

sorenlouv commented May 5, 2018 •

edited

Loading

goto-bus-stop commented May 5, 2018 •

edited

Loading