Incorrect "keyword" value for the key of object property which looks like an boolean

[markelog]

For the case like

({true: 1})

token for the key, will look like this -

{
  "type": {
    "label": "true",
    "keyword": "true",
    "beforeExpr": false,
    "startsExpr": true,
    "rightAssociative": false,
    "isLoop": false,
    "isAssign": false,
    "prefix": false,
    "postfix": false,
    "binop": null,
    "updateContext": null
  },
  "value": "true"
}

I believe "keyword": "true" bit should look like this - "keyword": undefined or "keyword": false

[hzoo]

This is probably true for other keywords as object keys like say function then right?

[markelog]

yeah

[loganfsmyth]

It is a keyword though, right? It's just that in this instance, a keyword is allowed as a name, it doesn't make the token less of a keyword token.

[mdevils]

Keyword token plays role of a keyword. In this case it's just an identifier.

[markelog]

I'd say it is a matter of interpretation - like in ast it is definitely an identifier, whereas in tokens list it is could be interpreted as keyword (and might be useful in some situations), although, tokens are needed to do an ast and it is pretty hard to distinguish it from other entities, since those and this token are identical, so we would need to analyze the surroundings and stuff. On the other hand other tokenizers consider this a keyword.

I think everybody would win if we would add a clarifier - another flag, property. As a bonus no one would consider this a breaking change, if that sounds acceptable we can provide a pr btw.

Also, on the side note - i think for the case like

({ "something": 1 })

keyword property for something token shouldn't be an undefined but false?

[babel-bot]

This issue has been moved to babel/babel#6724.