This repository has been archived by the owner on May 19, 2018. It is now read-only.
[WIP] Slightly better error messages #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'd like to see this. |
Instead of "Unexpected token" we now print "Unexpected token, expected <type.label>"
Current coverage is 94.50% (diff: 100%)@@ master #150 diff @@
==========================================
Files 19 19
Lines 3132 3132
Methods 328 328
Messages 0 0
Branches 826 826
==========================================
+ Hits 2959 2960 +1
Misses 94 94
+ Partials 79 78 -1
|
|
Got a timeout error and one of the dependencies is failing node 0.12 for some reason but we can still merge |
motiz88
added a commit
to motiz88/babylon
that referenced
this pull request
Oct 14, 2016
Expanding on babel#150, this allows `unexpected()` to accept the expected token type instead of a message string. This overload is then used in a couple more places (that independently implement a logic similar to `expect()`'s) to construct an `Unexpected token, expected FOO` message.
hzoo
pushed a commit
that referenced
this pull request
Oct 14, 2016
Expanding on #150, this allows `unexpected()` to accept the expected token type instead of a message string. This overload is then used in a couple more places (that independently implement a logic similar to `expect()`'s) to construct an `Unexpected token, expected FOO` message.
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
* Slightly better errors Instead of "Unexpected token" we now print "Unexpected token, expected <type.label>"
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
Expanding on babel#150, this allows `unexpected()` to accept the expected token type instead of a message string. This overload is then used in a couple more places (that independently implement a logic similar to `expect()`'s) to construct an `Unexpected token, expected FOO` message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
Unexpected tokenwe now printUnexpected token, expected <type.label>in the cases where we have the information. (see test failures for examples)I did not yet fix the tests, wanted to hear first what you think about that. It is not that big of an improvement but maybe better than what was there before.