Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Fix flowtype and add inType to state #189

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Fix flowtype and add inType to state #189

merged 1 commit into from
Oct 17, 2016

Conversation

danez
Copy link
Member

@danez danez commented Oct 16, 2016

This improves the performance slightly (because of hidden classes https://gist.github.com/twokul/9501770#hidden-classes)

from

name                            run   
./fixtures/angular.js           735ms 
./fixtures/backbone.js          71ms  
./fixtures/ember.debug.js       1873ms
./fixtures/jquery.js            362ms 
./fixtures/react-with-addons.js 769ms 

to

name                            run   
./fixtures/angular.js           699ms 
./fixtures/backbone.js          66ms  
./fixtures/ember.debug.js       1805ms
./fixtures/jquery.js            346ms 
./fixtures/react-with-addons.js 726ms 

This is the benchmark: https://github.com/danez/babylon_performance

babylon yarn linked, 100 iterations, node 6.8. Although the numbers seem to vary a lot even with 100 iterations.

this improves the performance slightly
@codecov-io
Copy link

codecov-io commented Oct 16, 2016

Current coverage is 96.15% (diff: 100%)

Merging #189 into master will not change coverage

@@             master       #189   diff @@
==========================================
  Files            19         19          
  Lines          3169       3169          
  Methods         333        333          
  Messages          0          0          
  Branches        832        832          
==========================================
  Hits           3047       3047          
  Misses           63         63          
  Partials         59         59          

Powered by Codecov. Last update 9b6e243...9f3baf3

@hzoo hzoo merged commit 0d72a89 into babel:master Oct 17, 2016
kristofdegrave pushed a commit to kristofdegrave/babylon that referenced this pull request Oct 27, 2016
this improves the performance slightly
@danez danez deleted the danez-patch-1 branch November 9, 2016 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants