Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Correctly eat semicolon at the end of DelcareModuleExports #223

Merged
merged 1 commit into from
Nov 14, 2016
Merged

Correctly eat semicolon at the end of DelcareModuleExports #223

merged 1 commit into from
Nov 14, 2016

Conversation

danez
Copy link
Member

@danez danez commented Nov 13, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

Without this patch this fails

declare module "foo" { declare module.exports: number; }

but this works

declare module "foo" { declare module.exports: number }

In flow both works.

@codecov-io
Copy link

codecov-io commented Nov 13, 2016

Current coverage is 97.69% (diff: 100%)

Merging #223 into master will increase coverage by <.01%

@@             master       #223   diff @@
==========================================
  Files            19         19          
  Lines          3214       3215     +1   
  Methods         336        336          
  Messages          0          0          
  Branches        838        838          
==========================================
+ Hits           3140       3141     +1   
  Misses           30         30          
  Partials         44         44          

Powered by Codecov. Last update c30a556...ad88d46

@hzoo hzoo merged commit 48873f8 into babel:master Nov 14, 2016
@danez danez deleted the declare-fix branch November 14, 2016 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants