This repository has been archived by the owner. It is now read-only.

Allow plugins:["*"] #229

Merged
merged 2 commits into from Nov 18, 2016

Conversation

Projects
None yet
4 participants
@danez
Copy link
Member

danez commented Nov 17, 2016

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets no
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Nov 17, 2016

A test using * would be good 😄

@hzoo hzoo added i: bug and removed i: enhancement labels Nov 18, 2016

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Nov 18, 2016

a bug fix since it should of worked before?

@hzoo hzoo merged commit 6d3b634 into babel:master Nov 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krainboltgreene

This comment has been minimized.

Copy link

krainboltgreene commented Nov 19, 2016

Does this mean I can automatically load all plugins I have installed? How does it figure out which package is a plugin?

@DrewML

This comment has been minimized.

Copy link
Member

DrewML commented Nov 19, 2016

@krainboltgreene Bablyon doesn't support external plugins (so plugin is a bit of a misnomer here). The plugins option takes an array of strings for built-in parser plugins. This PR just makes it easier for tooling (like astexplorer or babel-eslint) to enable all parser options without having to maintain a separate list.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Nov 19, 2016

Right this is only for the parser plugins https://github.com/babel/babylon#plugins - it's basically a truthy check in the parser to either make it say "unexpected token" or to parse it.

@danez danez deleted the danez:allow-star-plugins branch Apr 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.