Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Allow plugins:["*"] #229

Merged
merged 2 commits into from
Nov 18, 2016
Merged

Allow plugins:["*"] #229

merged 2 commits into from
Nov 18, 2016

Conversation

danez
Copy link
Member

@danez danez commented Nov 17, 2016

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets no

@hzoo
Copy link
Member

hzoo commented Nov 17, 2016

A test using * would be good 😄

@hzoo
Copy link
Member

hzoo commented Nov 18, 2016

a bug fix since it should of worked before?

@hzoo hzoo merged commit 6d3b634 into babel:master Nov 18, 2016
@krainboltgreene
Copy link

Does this mean I can automatically load all plugins I have installed? How does it figure out which package is a plugin?

@DrewML
Copy link
Member

DrewML commented Nov 19, 2016

@krainboltgreene Bablyon doesn't support external plugins (so plugin is a bit of a misnomer here). The plugins option takes an array of strings for built-in parser plugins. This PR just makes it easier for tooling (like astexplorer or babel-eslint) to enable all parser options without having to maintain a separate list.

@hzoo
Copy link
Member

hzoo commented Nov 19, 2016

Right this is only for the parser plugins https://github.com/babel/babylon#plugins - it's basically a truthy check in the parser to either make it say "unexpected token" or to parse it.

@danez danez deleted the allow-star-plugins branch April 21, 2017 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants