This repository has been archived by the owner. It is now read-only.

Prepare tests for multiple fixture runners. #240

Merged
merged 2 commits into from Dec 8, 2016

Conversation

Projects
None yet
2 participants
@danez
Copy link
Member

danez commented Nov 28, 2016

This refactor the test file, and extracts the actual code into a util file, so that we can create a second fixture runner in future. This is a preparation for #213

The only codechange is the remove of lodash and the usage of native iterators.

@danez danez added the Tag: Internal label Nov 28, 2016

@jeromew

This comment has been minimized.

Copy link
Contributor

jeromew commented Dec 6, 2016

@danez thanks for this PR. I was looking into how I could add tests for #213 and was going to ask if I could add a separate fixture directory for this ;-)
I'll wait until this PR is merged. Can you tell me on #213 what do you think the name should be for the fixture dir and a bit about the coverage that I should try to reach in the PR ?

@danez danez merged commit 375838d into babel:master Dec 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danez danez deleted the danez:optimize-tests branch Dec 8, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.