This repository has been archived by the owner on May 19, 2018. It is now read-only.
Don't set inType flag when parsing property names #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharper
approved these changes
Dec 22, 2016
xtuc
approved these changes
Dec 24, 2016
| @@ -0,0 +1,3 @@ | |||
| const map = { | |||
| [age <= 17] : 'Too young' | |||
There was a problem hiding this comment.
Do we need the original use case? It's not important in the expected AST.
I would suggest something like that:
[1 <= 0]: null
danez
reviewed
Dec 24, 2016
| @@ -16,6 +16,7 @@ export default class State { | |||
| this.inFunction = | |||
| this.inGenerator = | |||
| this.inAsync = | |||
| this.inPropertyName = | |||
There was a problem hiding this comment.
Can you please also add the flow type, like the other fields?
danez
reviewed
Dec 24, 2016
| @@ -416,6 +416,10 @@ export default function(instance) { | |||
| return function(code) { | |||
| let context = this.curContext(); | |||
|
|
|||
| if (this.state.inPropertyName) { | |||
| return inner.call(this, code); | |||
| } | |||
There was a problem hiding this comment.
We could move this before the curContext() call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
inTypeflag was set when parsing property names. Among other things it was used to prevent jsx tokenization. This patch adds specializedinPropertyNameflag and prevent jsx tokenization in jsx plugin.