This repository has been archived by the owner. It is now read-only.

Fail tests that have expected.json and throws-option #285

Merged
merged 2 commits into from Jan 12, 2017

Conversation

Projects
None yet
2 participants
@danez
Copy link
Member

danez commented Jan 11, 2017

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets
License MIT

I can fix the now failing tests at some point, but just noticed it during testing and don't have time right now.

If anyone wants to do this, feel free to either add commits here (as maintainer), or copy my commit into another PR.
(I would probably do it with a one time script or regex to parse the test output for expected.json locations and do rm on them.)

Daniel Tschinder
Daniel Tschinder
@danez

This comment has been minimized.

Copy link
Member Author

danez commented Jan 12, 2017

Removed with

node_modules/.bin/ava -v 2>&1 | sed -r "s/\x1B\[([0-9]{1,2}(;[0-9]{1,2})?)?[mGK]//g" | ggrep -P -o "([^\s]*?)/actual.js" | sed s/actual\.js/expected.json/ | sed s/^/test\\/fixtures\\// | xargs rm
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 12, 2017

Current coverage is 97.46% (diff: 100%)

Merging #285 into master will not change coverage

@@             master       #285   diff @@
==========================================
  Files            21         21          
  Lines          3991       3991          
  Methods         488        474    -14   
  Messages          0          0          
  Branches       1167       1181    +14   
==========================================
  Hits           3890       3890          
  Misses           44         44          
  Partials         57         57          

Powered by Codecov. Last update aa1a4be...2ddd0ed

@danez danez merged commit 13bebfd into master Jan 12, 2017

4 checks passed

codecov/patch Coverage not affected when comparing aa1a4be...2ddd0ed
Details
codecov/project 97.46% (+0.00%) compared to aa1a4be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the flag-invalid-tests branch Jan 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.