This repository has been archived by the owner. It is now read-only.

Fix ObjectTypeCallProperty static #298

Merged
merged 2 commits into from Jan 16, 2017

Conversation

Projects
None yet
5 participants
@danharper
Copy link
Member

danharper commented Jan 14, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #297
License MIT

flowParseObjectTypeCallProperty was always being passed allowStatic instead of isStatic.

@vjeux

This comment has been minimized.

Copy link

vjeux commented Jan 14, 2017

Omg, thanks for the super quick fix!

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Jan 14, 2017

fyi @danharper is also on the Babel team 😄

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 14, 2017

Current coverage is 97.47% (diff: 100%)

Merging #298 into master will not change coverage

@@             master       #298   diff @@
==========================================
  Files            21         21          
  Lines          3993       3993          
  Methods         489        492     +3   
  Messages          0          0          
  Branches       1167       1164     -3   
==========================================
  Hits           3892       3892          
  Misses           44         44          
  Partials         57         57          

Powered by Codecov. Last update 9d78213...a9696e8

@danez

danez approved these changes Jan 14, 2017

@danez danez merged commit 28c467e into master Jan 16, 2017

4 checks passed

codecov/patch 100% of diff hit (target 97.47%)
Details
codecov/project 97.47% (+0.00%) compared to 9d78213
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the fix297 branch Jan 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.