This repository has been archived by the owner on May 19, 2018. It is now read-only.
keywords are not allowed as local specifier in imports #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.19% (diff: 100%)@@ master #307 diff @@
==========================================
Files 21 21
Lines 3487 3492 +5
Methods 400 400
Messages 0 0
Branches 896 895 -1
==========================================
+ Hits 3387 3394 +7
+ Misses 44 43 -1
+ Partials 56 55 -1
|
danez
force-pushed
the
fix-import-keyword
branch
2 times, most recently
from
50c9845
to
a6ad78d
Compare
Also fix some error messages to be more specific
danez
force-pushed
the
fix-import-keyword
branch
from
a6ad78d
to
fe21e06
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be allowed
https://www.ecma-international.org/ecma-262/7.0/#prod-BindingIdentifier
The Identifier is an BindingIdentifier and the spec says not ReservedKeyword
As flow completely overwrites the parsing I also had to change it there.
Furthermore I fixed the implementation in the flow plugin to consider keywords and not only names and also changed parsing Identifier to always do the ReservedKeyword check, so that the error message gets clearer.
Before:
Unexpected token(what else would it be?)After :
<keyword> is a reserved word