Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Reintroduce Variance node #333

Merged
merged 2 commits into from
Feb 12, 2017
Merged

Reintroduce Variance node #333

merged 2 commits into from
Feb 12, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jan 27, 2017

Q A
Bug fix? no
Breaking change? yes
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets Fixes babel/babel#4722
License MIT

This reverts the change that made variance a string literal and reintroduces the Variance node.

//cc @samwgoldman

@codecov-io
Copy link

codecov-io commented Jan 27, 2017

Codecov Report

Merging #333 into 7.0 will increase coverage by 0.7%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##              7.0     #333     +/-   ##
=========================================
+ Coverage   97.46%   98.17%   +0.7%     
=========================================
  Files          19       19             
  Lines        3237     4380   +1143     
  Branches      847     1398    +551     
=========================================
+ Hits         3155     4300   +1145     
+ Misses         35       34      -1     
+ Partials       47       46      -1
Impacted Files Coverage Δ
src/plugins/flow.js 97.53% <100%> (+0.8%)
src/parser/lval.js 98.55% <ø> (-0.1%)
src/parser/statement.js 97.89% <ø> (-0.01%)
src/util/identifier.js 100% <ø> (ø)
src/index.js 100% <ø> (ø)
src/plugins/jsx/index.js 98.4% <ø> (+0.62%)
src/tokenizer/index.js 99.04% <ø> (+0.77%)
src/parser/expression.js 98.3% <ø> (+1.85%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c424156...2bdc201. Read the comment docs.

tt.plusMin can only be + or - so no need to have an elseif
@danez danez merged commit 1cca700 into 7.0 Feb 12, 2017
@danez danez deleted the variance-node branch February 12, 2017 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants