This repository has been archived by the owner. It is now read-only.

Fix #336 by correctly setting arrow-param #337

merged 1 commit into from Feb 10, 2017


None yet
2 participants
Copy link

danez commented Jan 31, 2017

Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets Fixes #336
License MIT

The param refNeedsArrowPos of parseMaybeAssign() wasn't populated in the failing case.

Tbh this params (refShorthandDefaultPos, refNeedsArrowPos) are very magic to me and it takes a while to see what they do. When I have time again I will try to remove them and instead try to use the state for this with speaking names, but I'm not sure if that is possible.

Daniel Tschinder

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #337 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
  Coverage   97.65%   97.65%           
  Files          20       20           
  Lines        3326     3326           
  Branches      882      882           
  Hits         3248     3248           
  Misses         30       30           
  Partials       48       48
Impacted Files Coverage Δ
src/parser/expression.js 97.32% <100%> (ø)
src/plugins/flow.js 97.52% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c4a7...7322001. Read the comment docs.

@danez danez merged commit bc771bd into master Feb 10, 2017

4 checks passed

codecov/patch 100% of diff hit (target 97.65%)
codecov/project 97.65% (+0%) compared to 898c4a7
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@danez danez deleted the fix-336 branch Feb 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.