Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Fix #336 by correctly setting arrow-param #337

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix #336 by correctly setting arrow-param #337

merged 1 commit into from
Feb 10, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jan 31, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets Fixes #336
License MIT

The param refNeedsArrowPos of parseMaybeAssign() wasn't populated in the failing case.

Tbh this params (refShorthandDefaultPos, refNeedsArrowPos) are very magic to me and it takes a while to see what they do. When I have time again I will try to remove them and instead try to use the state for this with speaking names, but I'm not sure if that is possible.

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #337 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          20       20           
  Lines        3326     3326           
  Branches      882      882           
=======================================
  Hits         3248     3248           
  Misses         30       30           
  Partials       48       48
Impacted Files Coverage Δ
src/parser/expression.js 97.32% <100%> (ø)
src/plugins/flow.js 97.52% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c4a7...7322001. Read the comment docs.

@danez danez merged commit bc771bd into master Feb 10, 2017
@danez danez deleted the fix-336 branch February 10, 2017 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse error on named optional param in async arrow function type annotation
2 participants