Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Move plugin helpers out of Parser.prototype and into the plugin itself #482

Merged
merged 1 commit into from Apr 23, 2017
Merged

Move plugin helpers out of Parser.prototype and into the plugin itself #482

merged 1 commit into from Apr 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2017

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? Tests pass
Fixed tickets
License MIT

Plugins used to define helper functions and overrides separately, likely to avoid adding too many instance fields to the parser object. Now that each plugin is a class (#459), that is no longer necessary.

I tested with the perf script and this doesn't seem to have any impact.

@codecov
Copy link

codecov bot commented Apr 21, 2017

Codecov Report

Merging #482 into master will decrease coverage by <.01%.
The diff coverage is 99.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files          20       20              
  Lines        3531     3528       -3     
  Branches      973      973              
==========================================
- Hits         3469     3466       -3     
  Misses         23       23              
  Partials       39       39
Flag Coverage Δ
#babel 81% <76.79%> (-0.22%) ⬇️
#babylon 97.08% <99.13%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/plugins/estree.js 99.16% <100%> (-0.01%) ⬇️
src/plugins/jsx/index.js 97.7% <97.01%> (-0.01%) ⬇️
src/plugins/flow.js 98.15% <99.82%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8601f2f...46f1eec. Read the comment docs.

@danez danez merged commit 2c1193b into babel:master Apr 23, 2017
@ghost ghost deleted the plugin_helpers branch April 25, 2017 15:12
@ghost ghost mentioned this pull request May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants