Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Type-check tokenizer/types.js #493

Merged
merged 1 commit into from Apr 27, 2017
Merged

Type-check tokenizer/types.js #493

merged 1 commit into from Apr 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2017

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? Tests pass
Fixed tickets
License MIT

Enables type-checking in the file and adds type annotations.

Also changed the implementation of unexpected to something that would type-check. It should be equivalent given the allowed inputs; we don't need to test for non-nullity or for the presence of .label assuming callers respect the type.

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #493   +/-   ##
======================================
  Coverage    98.2%   98.2%           
======================================
  Files          21      21           
  Lines        3517    3517           
  Branches      974     974           
======================================
  Hits         3454    3454           
  Misses         24      24           
  Partials       39      39
Flag Coverage Δ
#babel 80.89% <100%> (ø) ⬆️
#babylon 97.04% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/tokenizer/context.js 100% <ø> (ø) ⬆️
src/tokenizer/types.js 100% <100%> (ø) ⬆️
src/parser/util.js 90% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7627c5a...d83f54e. Read the comment docs.

@hzoo hzoo merged commit 8288f7d into babel:master Apr 27, 2017
@ghost ghost deleted the tokenizer_types branch April 27, 2017 15:28
@ghost ghost mentioned this pull request May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants