This repository has been archived by the owner on May 19, 2018. It is now read-only.
Type-check flow plugin #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 98.2% 98.26% +0.05%
==========================================
Files 21 21
Lines 3517 3516 -1
Branches 974 973 -1
==========================================
+ Hits 3454 3455 +1
+ Misses 24 22 -2
Partials 39 39
Continue to review full report at Codecov.
|
src/plugins/flow.js
Outdated
| @@ -1018,8 +1035,8 @@ export default (superClass) => class extends superClass { | |||
| } | |||
| } | |||
|
|
|||
| // declares, interfaces and type aliases | |||
| parseExpressionStatement(node, expr) { | |||
| // declares, interfaces and tNype aliases | |||
existentialism
approved these changes
Apr 27, 2017
hzoo
reviewed
Apr 27, 2017
| node.default = false; | ||
| delete node.exportKind; | ||
| } | ||
|
|
||
| // $FlowIgnore | ||
| node.type = "Declare" + node.type; |
There was a problem hiding this comment.
Type systems don't handle objects changing type very well. There are similar problems in the estree plugin.
There was a problem hiding this comment.
Yeah it's just not a good way to handle the types, dynamically adding the strings
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables type-checking in the file and adds type annotations.
This isn't a very strict check since the spec for the node types isn't done.