This repository has been archived by the owner on May 19, 2018. It is now read-only.
Better error message for anonymous class declarations #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 22 22
Lines 3524 3524
Branches 977 977
=======================================
Hits 3463 3463
Misses 22 22
Partials 39 39
Continue to review full report at Codecov.
|
hzoo
approved these changes
May 4, 2017
There was a problem hiding this comment.
Love it - dono if anyone else had opinions on the message itself
other suggestions: (probably bad since maybe shorter is better in this case) - most of the time you would have the codeframe anyway with Babel.
- a class name is required
- class names are required if not a default export
|
Cool - I also like "A class name is required". Thoughts/suggestions from
anyone else?
I'll probably leave as is if nobody else has an opinion if that's cool
…On Wed, May 3, 2017, 21:38 Henry Zhu ***@***.***> wrote:
***@***.**** approved this pull request.
Love it - dono if anyone else had opinions on the message itself
other suggestions: (probably bad since maybe shorter is better in this
case) - most of the time you would have the codeframe anyway with Babel.
- a class name is required
- class names are required if not a default export
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#509 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAq_LgFGBmB7W9wNbo019pB8vdnbGNEtks5r2VYugaJpZM4NQK3T>
.
|
existentialism
approved these changes
May 4, 2017
rattrayalex
force-pushed
the
class-name-error-babylon
branch
from
65ba7e4
to
e2014e2
Compare
|
Awesome, thanks guys! Updated to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given code like:
or
Instead of
Unexpected token (1:6), getClass name required (1:6)