Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

update babel alpha 12, fixes build issues #583

Merged
merged 1 commit into from Jun 18, 2017
Merged

update babel alpha 12, fixes build issues #583

merged 1 commit into from Jun 18, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jun 17, 2017

No description provided.

@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #583 into master will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   98.15%   96.81%   -1.34%     
==========================================
  Files          22       22              
  Lines        3677     3675       -2     
  Branches     1025     1024       -1     
==========================================
- Hits         3609     3558      -51     
- Misses         25       60      +35     
- Partials       43       57      +14
Flag Coverage Δ
#babel ?
#babylon 96.81% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/parser/comments.js 87.87% <0%> (-6.07%) ⬇️
src/parser/expression.js 93.57% <0%> (-3.36%) ⬇️
src/tokenizer/state.js 97.14% <0%> (-2.86%) ⬇️
src/plugins/flow.js 97.36% <0%> (-1.04%) ⬇️
src/tokenizer/index.js 97.47% <0%> (-0.98%) ⬇️
src/parser/statement.js 98.23% <0%> (-0.89%) ⬇️
src/util/location.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e982c06...0b9f3e1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #583 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   97.99%   98.18%   +0.18%     
==========================================
  Files          22       22              
  Lines        3685     3960     +275     
  Branches     1028     1183     +155     
==========================================
+ Hits         3611     3888     +277     
+ Misses         27       25       -2     
  Partials       47       47
Flag Coverage Δ
#babel 81.23% <ø> (+0.8%) ⬆️
#babylon 96.99% <ø> (+0.22%) ⬆️
Impacted Files Coverage Δ
src/util/location.js 100% <0%> (ø) ⬆️
src/tokenizer/state.js 100% <0%> (ø) ⬆️
src/plugins/estree.js 99.36% <0%> (+0.14%) ⬆️
src/tokenizer/index.js 98.75% <0%> (+0.31%) ⬆️
src/parser/comments.js 92.22% <0%> (+6.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb09891...beaa0f8. Read the comment docs.

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if and what might be different in the generated bundle. Although in theory nothing should change?

@danez
Copy link
Member

danez commented Jun 17, 2017

Maybe we should also turn of the codecov PR comments, they get really annoying:

  • It posts multiple times recently
  • The information is not useful and also available in the PR checks

@hzoo
Copy link
Member Author

hzoo commented Jun 17, 2017

Yeah I basically ignore them now..

@hzoo hzoo merged commit 8febb09 into master Jun 18, 2017
@danez danez deleted the update-babel branch June 19, 2017 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants