Skip to content
This repository has been archived by the owner. It is now read-only.

Rename PrivateName.name to .id #698

Merged
merged 1 commit into from Aug 28, 2017

Conversation

@Qantas94Heavy
Copy link
Member

Qantas94Heavy commented Aug 26, 2017

Q A
Bug fix? yes
Breaking change? not for release
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets N/A
License MIT

Given that it refers to an identifier, it's somewhat confusing to have
to use .name.name to get the actual string. The type declared within
types.js is also incorrect, which this commit fixes.

This will also require anything using PrivateName in the main Babel repository to be changed, but it's probably better we do this now rather than after release.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 26, 2017

@hzoo hzoo requested review from diervo and littledan Aug 26, 2017
Given that it refers to an identifier, it's somewhat confusing to have
to use .name.name to get the actual string. The type declared within
types.js is also incorrect, which this commit fixes.
@Qantas94Heavy Qantas94Heavy force-pushed the Qantas94Heavy:privatename-id branch from f325bc2 to c169f05 Aug 27, 2017
@Qantas94Heavy

This comment has been minimized.

Copy link
Member Author

Qantas94Heavy commented Aug 28, 2017

Done.

@jridgewell jridgewell merged commit 19bc694 into babel:master Aug 28, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 95.7%)
Details
codecov/project 95.7% (+0%) compared to 6d24416
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
facebook-github-bot added a commit to facebook/flow that referenced this pull request Aug 31, 2017
Summary:
stay in sync with Babylon until estree/estree#154 is resolved

see babel/babylon#698

Reviewed By: avikchaudhuri

Differential Revision: D5744770

fbshipit-source-id: d89f474055b112a2a8025dab9a19a3f98061fd64
mroch added a commit to facebook/flow that referenced this pull request Aug 31, 2017
Summary:
stay in sync with Babylon until estree/estree#154 is resolved

see babel/babylon#698

Reviewed By: avikchaudhuri

Differential Revision: D5744770

fbshipit-source-id: 22f67cba14dbf39720424e81875d9a2dc3e4967f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.