-
-
Notifications
You must be signed in to change notification settings - Fork 257
Allow new.target in class properties #759
Conversation
existentialism
commented
Oct 13, 2017
Q | A |
---|---|
Bug fix? | yes |
Breaking change? | no |
New feature? | no |
Deprecations? | no |
Spec compliancy? | yes |
Tests added/pass? | yes |
Fixed tickets | Fixes #758 |
License | MIT |
Is Also, I think |
/cc @littledan, what's the expected behavior here? |
Related: babel/babel#6243 |
|
1a45222
to
4102925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved too early 😅
Can you add a test for the new.target can only be used in functions or class properties
error message, so we get full coverage for this PR?
Would it make sense to add a test that verifies that, when you execute the code, you actually get undefined for new.target in these cases? |
I think we should add them, but they must be in the Babel repository (after this PR is merged) |
4102925
to
17da758
Compare
LGTM |
This will be better when babylon is merged into the monorepo |