This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix arrow functions with destructuring, types & default value #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow's "toAssignable" override wasn't calling the inner function, resulting in the destructuring in an AssignmentPattern not having the node type changed from ObjectExpression to ObjectPattern, resulting in "Binding rvalue" thrown from "checkLVal()"
Current coverage is 96.91% (diff: 100%)@@ master #94 diff @@
==========================================
Files 19 19
Lines 2922 2922
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2832 2832
Misses 90 90
Partials 0 0
|
|
Good catch. Thanks for your contribution. lgtm |
| @@ -878,11 +878,11 @@ export default function (instance) { | |||
| }); | |||
|
|
|||
| instance.extend("toAssignable", function (inner) { | |||
| return function (node) { | |||
| return function (node, isBinding) { | |||
There was a problem hiding this comment.
We can probably use ...args here and pass that down right? (although I see there's only 2 params)
works fine though
There was a problem hiding this comment.
That's what I originally had tbh, then noticed toAssignableList was being explicit with the args.
Shall I change it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
var x = ({ a } : any = 'foo') => {}Will currently throw: "Binding rvalue"
Flow's
toAssignableoverride wasn't calling the inner function after setting the type annotation, resulting in the node not having the type clarified fromObjectExpressiontoObjectPattern(which would later cause it to throw asObjectExpressionisn't a valid lval).