This repository has been archived by the owner. It is now read-only.

Fix issues with flow-types and async function #95

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
3 participants
@danez
Copy link
Member

danez commented Aug 18, 2016

I noticed that #92 actually contains two bugs, so I splited them into two separate PRs.

This one resolves the issue with

const a = async (b:string = '') => {};

The fix here was simply to also call this.parseParenItem which without flow is doing nothing, but with flow enabled it is actually parsing the type annotation.

Fixes #92

Daniel Tschinder
Fix issues with flow-types and async function
the typeAnnotation was not correctly resolved in async
functions
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 18, 2016

Current coverage is 96.78% (diff: 100%)

Merging #95 into master will decrease coverage by 0.13%

@@             master        #95   diff @@
==========================================
  Files            19         19          
  Lines          2922       2922          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           2832       2828     -4   
- Misses           90         94     +4   
  Partials          0          0          

Powered by Codecov. Last update b649671...b027d44

@danez danez added the Tag: Bug Fix label Aug 19, 2016

@hzoo hzoo merged commit db0705b into babel:master Aug 23, 2016

3 checks passed

codecov/patch 100% of diff hit (target 96.91%)
Details
codecov/project Absolute coverage decreased by -0.13% but relative coverage increased by +3.08% compared to b649671
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danez danez deleted the danez:flow-92 branch Aug 31, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.