This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix issues with flow-types and async function #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the typeAnnotation was not correctly resolved in async functions
Current coverage is 96.78% (diff: 100%)@@ master #95 diff @@
==========================================
Files 19 19
Lines 2922 2922
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2832 2828 -4
- Misses 90 94 +4
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #92 actually contains two bugs, so I splited them into two separate PRs.
This one resolves the issue with
The fix here was simply to also call
this.parseParenItemwhich without flow is doing nothing, but with flow enabled it is actually parsing the type annotation.Fixes #92